Skip to content

mantle/kola/tests: adapt mpath verification #4113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
joelcapitao merged 2 commits into from
Jun 3, 2025
Merged

mantle/kola/tests: adapt mpath verification #4113

joelcapitao merged 2 commits into from
Jun 3, 2025

Conversation

@joelcapitao
Copy link
Member

@joelcapitao joelcapitao commented May 21, 2025

The test needs to be adapted so it doesn't verify that we're on multipath based on whether the device is /dev/mapper/mpath or not, but instead based on udevadm output.

@openshift-ci
Copy link

openshift-ci bot commented May 21, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@joelcapitao joelcapitao force-pushed the adapt_mpath_verification branch from 3d6361a to 8a30a63 Compare May 21, 2025 10:11
@joelcapitao joelcapitao marked this pull request as ready for review May 21, 2025 10:53
@joelcapitao joelcapitao mentioned this pull request May 21, 2025
Merged
@joelcapitao joelcapitao force-pushed the adapt_mpath_verification branch 2 times, most recently from 912dfdc to a010061 Compare May 21, 2025 11:47
@dustymabe
Copy link
Member

dustymabe commented May 21, 2025

Running the multipath.partition test locally I don't see how this update will work:

[core@qemu0 ~]$ findmnt -nvr /var/lib/containers -o SOURCE
/dev/mapper/mpatha
[core@qemu0 ~]$ udevadm info /dev/mapper/mpatha | cat
P: /devices/virtual/block/dm-0
M: dm-0
R: 0
J: b252:0
U: block
T: disk
D: b 252:0
N: dm-0
L: 50
S: disk/by-uuid/dm-mpath-a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
S: disk/by-label/dm-mpath-containers
S: disk/by-id/dm-name-mpatha
S: disk/by-label/containers
S: disk/by-id/scsi-0xd5f7e2fb9beb72d6
S: disk/by-diskseq/4
S: disk/by-id/wwn-0xxd5f7e2fb9beb72d6
S: disk/by-uuid/a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
S: mapper/mpatha
S: disk/by-id/dm-uuid-mpath-0xd5f7e2fb9beb72d6
Q: 4
E: DEVPATH=/devices/virtual/block/dm-0
E: DEVNAME=/dev/dm-0
E: DEVTYPE=disk
E: DISKSEQ=4
E: MAJOR=252
E: MINOR=0
E: SUBSYSTEM=block
E: USEC_INITIALIZED=9164907
E: DM_UDEV_DISABLE_LIBRARY_FALLBACK_FLAG=1
E: DM_UDEV_PRIMARY_SOURCE_FLAG=1
E: DM_UDEV_RULES_VSN=3
E: DM_NAME=mpatha
E: DM_UUID=mpath-0xd5f7e2fb9beb72d6
E: MPATH_DEVICE_READY=1
E: DM_TYPE=scsi
E: DM_WWN=0xxd5f7e2fb9beb72d6
E: DM_SERIAL=0xd5f7e2fb9beb72d6
E: ID_FS_LABEL=containers
E: ID_FS_LABEL_ENC=containers
E: ID_FS_UUID=a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
E: ID_FS_UUID_ENC=a4da5870-d6c8-4c02-b420-2f9f14d2bd9f
E: ID_FS_SIZE=1006632960
E: ID_FS_LASTBLOCK=262144
E: ID_FS_BLOCKSIZE=4096
E: ID_FS_TYPE=xfs
E: ID_FS_USAGE=filesystem
E: NVME_HOST_IFACE=none
E: DEVLINKS=/dev/disk/by-uuid/dm-mpath-a4da5870-d6c8-4c02-b420-2f9f14d2bd9f /dev/disk/by-label/dm-mpath-containers /dev/disk/by-id/dm-name-mpatha /dev/disk/by-label/containers /dev/disk/by-id/scsi-0xd5f7e2fb9beb72d6 /dev/disk/by-diskseq/4 /dev/disk/by-id/wwn-0xxd5f7e2fb9beb72d6 /dev/disk/by-uuid/a4da5870-d6c8-4c02-b420-2f9f14d2bd9f /dev/mapper/mpatha /dev/disk/by-id/dm-uuid-mpath-0xd5f7e2fb9beb72d6
E: TAGS=:systemd:
E: CURRENT_TAGS=:systemd:

There's no DM_MPATH string in there.

@joelcapitao joelcapitao force-pushed the adapt_mpath_verification branch from a010061 to fcb9912 Compare May 22, 2025 10:17
@joelcapitao joelcapitao marked this pull request as draft May 22, 2025 10:18
@joelcapitao joelcapitao force-pushed the adapt_mpath_verification branch from fcb9912 to 2af72ea Compare May 22, 2025 14:56
@dustymabe
Copy link
Member

dustymabe commented May 22, 2025

@jlebon in the var lib containers mpath test we have:

coreos-assembler/mantle/kola/tests/misc/multipath.go

Line 54 in 6ec2120

ExecStart=/usr/sbin/mpathconf --enable

and then use mpatha throughout that particular test. Should we be specifying userfriendlynames=no there and not using mpatha?

@joelcapitao joelcapitao force-pushed the adapt_mpath_verification branch from 2af72ea to 00ba40f Compare May 26, 2025 10:10
@joelcapitao
Copy link
Member Author

joelcapitao commented May 26, 2025 •
edited
Loading

There's no DM_MPATH string in there.

Yeah, I dug up more on that, and moved to look for the DEVLINKS

and then use mpatha throughout that particular test. Should we be specifying userfriendlynames=no there and not using mpatha?

Good point, in last PS, I've specified a WWID to the stub device and disabled user-friendly names

@joelcapitao
mantle/kola/tests: adapt mpath verification
e952f26 
The test needs to be adapted so it doesn't verify that we're on
multipath based on whether the device is `/dev/mapper/mpath` or not,
but instead based on udevadm output.
This verification works whether or not the `user_friendly_names`
option is used while configuring multipath.
@joelcapitao
mantle/kola/tests: use WWID in multipath.partition
5290a96 
In order to have a more generic test, let's not use user-friendly names
while configuring multipath and specify instead a World Wide ID to the
stub device. We also adapt the systemd units accordingly.
@joelcapitao joelcapitao force-pushed the adapt_mpath_verification branch from 00ba40f to 5290a96 Compare May 26, 2025 15:31
@joelcapitao joelcapitao marked this pull request as ready for review May 26, 2025 16:57
@joelcapitao
Copy link
Member Author

joelcapitao commented May 27, 2025

/retest

1 similar comment
@joelcapitao
Copy link
Member Author

joelcapitao commented May 27, 2025

/retest

jbtrystram
jbtrystram approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@jbtrystram jbtrystram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! I think the two commits can be squashed

dustymabe
dustymabe approved these changes Jun 2, 2025
View reviewed changes
Copy link
Member

@dustymabe dustymabe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@joelcapitao joelcapitao merged commit 0444f22 into coreos:main Jun 3, 2025
5 checks passed
@joelcapitao
Copy link
Member Author

joelcapitao commented Nov 4, 2025

/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

https://gitlab.com/redhat/rhel/rpms/dracut/-/commit/8067fa3fb6b3c5f5c9272f927a79ae1810be9070 disabled user_friendly_names in rhel-9.4

@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 4, 2025

@joelcapitao: new pull request created: #4352

In response to this:

/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

https://gitlab.com/redhat/rhel/rpms/dracut/-/commit/8067fa3fb6b3c5f5c9272f927a79ae1810be9070 disabled user_friendly_names in rhel-9.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 4, 2025

@joelcapitao: new pull request created: #4353

In response to this:

/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

https://gitlab.com/redhat/rhel/rpms/dracut/-/commit/8067fa3fb6b3c5f5c9272f927a79ae1810be9070 disabled user_friendly_names in rhel-9.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2025
Merged
@openshift-cherrypick-robot
Copy link

openshift-cherrypick-robot commented Nov 4, 2025

@joelcapitao: new pull request created: #4354

In response to this:

/cherrypick rhcos-4.18
/cherrypick rhcos-4.17
/cherrypick rhcos-4.16

https://gitlab.com/redhat/rhel/rpms/dracut/-/commit/8067fa3fb6b3c5f5c9272f927a79ae1810be9070 disabled user_friendly_names in rhel-9.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@openshift-cherrypick-robot openshift-cherrypick-robot mentioned this pull request Nov 4, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dustymabe dustymabe dustymabe approved these changes

@jbtrystram jbtrystram jbtrystram approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@joelcapitao @dustymabe @openshift-cherrypick-robot @jbtrystram